[checkmk-commits] Check_MK Git: check_mk: #0201 FIX Fixed error message in Rulelist of RBN

Bastian Kuhn bk at mathias-kettner.de
Fri Aug 8 13:42:32 CEST 2014


Module: check_mk
Branch: master
Commit: 3dbd6f3baa4f5af53d87afe6ed329b02f6e6965e
URL:    http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3dbd6f3baa4f5af53d87afe6ed329b02f6e6965e

Author: Bastian Kuhn <bk at mathias-kettner.de>
Date:   Fri Aug  8 13:42:06 2014 +0200

#0201 FIX Fixed error message in Rulelist of RBN

There was an error with an incomple rule entrie who leads to an exception the
WATO Notification configuration.

---

 .werks/201         |   11 +++++++++++
 ChangeLog          |    1 +
 web/htdocs/wato.py |    4 ++++
 3 files changed, 16 insertions(+)

diff --git a/.werks/201 b/.werks/201
new file mode 100644
index 0000000..21b6467
--- /dev/null
+++ b/.werks/201
@@ -0,0 +1,11 @@
+Title: Fixed error message in Rulelist of RBN
+Level: 1
+Component: wato
+Class: fix
+Compatible: compat
+State: unknown
+Version: 1.2.5i6
+Date: 1407497923
+
+There was an error with an incomple rule entrie who leads to an exception the
+WATO Notification configuration.
diff --git a/ChangeLog b/ChangeLog
index 3920be5..d54ee8e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -38,6 +38,7 @@
     * 1092 FIX: logwatch: now able to enter unicode text into the "Pattern (Regex)" field
     * 0191 FIX: Added swp files to the ignore list for the WATO git feature...
     * 1153 FIX: Changed custom user attributes can now be used immediately...
+    * 0201 FIX: Fixed error message in Rulelist of RBN...
 
 
 1.2.5i5:
diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py
index e5d086c..8cc4126 100644
--- a/web/htdocs/wato.py
+++ b/web/htdocs/wato.py
@@ -8565,6 +8565,10 @@ def render_notification_rules(rules, userid="", show_title=False, show_buttons=T
                 html.empty_icon_button()
 
             notify_method = rule["notify_plugin"]
+            # catch rules with empty notify_plugin key
+            # TODO Mayby this should be avoided somewhere else ( e.g. rule editor)
+            if not notify_method:
+                notify_method = ( None, [] )
             notify_plugin = notify_method[0]
 
             table.cell(_("Type"), css="narrow")



More information about the checkmk-commits mailing list