[checkmk-commits] Check_MK Git: check_mk: FIX oracle_asm_diskgroup: Now really uses the generic filesystem levels

Lars Michelsen lm at mathias-kettner.de
Tue Feb 11 12:50:06 CET 2014


Module: check_mk
Branch: master
Commit: 8481df059d2d2332038a22363be818cacc74a3bc
URL:    http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8481df059d2d2332038a22363be818cacc74a3bc

Author: Lars Michelsen <lm at mathias-kettner.de>
Date:   Tue Feb 11 12:49:38 2014 +0100

FIX oracle_asm_diskgroup: Now really uses the generic filesystem levels

The check should but did not use the generic filesystem levels for inventorized
and manual checks, but it did not use them.

---

 .werks/667                  |   10 ++++++++++
 ChangeLog                   |    1 +
 checks/oracle_asm_diskgroup |   15 +++++++--------
 3 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/.werks/667 b/.werks/667
new file mode 100644
index 0000000..a5d7d6e
--- /dev/null
+++ b/.werks/667
@@ -0,0 +1,10 @@
+Title: oracle_asm_diskgroup: Now really uses the generic filesystem levels
+Level: 1
+Component: checks
+Version: 1.2.5i1
+Date: 1392119342
+Class: fix
+
+The check should but did not use the generic filesystem levels for inventorized
+and manual checks, but it did not use them.
+
diff --git a/ChangeLog b/ChangeLog
index c41c048..6744d6c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -172,6 +172,7 @@
     * 0279 FIX: check_mk_agent.solaris: removed proc section from statgrab...
     * 0281 FIX: statgrab_net.ctr: only inventorize interfaces with actual traffic...
     * 0582 FIX: cisco_sys_mem: check now has a man page and a new WATO integration
+    * 0667 FIX: oracle_asm_diskgroup: Now really uses the generic filesystem levels...
 
     Multisite:
     * 0371 Added log class filter to hostsvcevents view
diff --git a/checks/oracle_asm_diskgroup b/checks/oracle_asm_diskgroup
index 6b87008..d2528db 100644
--- a/checks/oracle_asm_diskgroup
+++ b/checks/oracle_asm_diskgroup
@@ -30,8 +30,6 @@
 # MOUNTED  NORMAL  N         512   4096  1048576      3072     2146              309             918              0             Y  OCR_VOTE/
 # The agent section <<<oracle_asm_diskgroup>>> does not output the header line
 
-check_includes['oracle_asm_diskgroup'] = [ "df.include" ]
-
 def inventory_oracle_asm_diskgroup(info):
     return [ (line[-1].rstrip("/"), {}) for line in info ]
 
@@ -47,10 +45,11 @@ def check_oracle_asm_diskgroup(item, params, info):
 
 
 check_info["oracle_asm_diskgroup"] = {
-    'check_function':          check_oracle_asm_diskgroup,
-    'inventory_function':      inventory_oracle_asm_diskgroup,
-    'service_description':     'ASM Diskgroup %s',
-    'has_perfdata':            True,
-    'group':                   'fs',
-    'default_levels_variable': 'filesystem_default_levels',
+    'check_function'          : check_oracle_asm_diskgroup,
+    'inventory_function'      : inventory_oracle_asm_diskgroup,
+    'service_description'     : 'ASM Diskgroup %s',
+    'has_perfdata'            : True,
+    'group'                   : 'filesystem',
+    'default_levels_variable' : 'filesystem_default_levels',
+    "includes"                : [ "df.include" ],
 }



More information about the checkmk-commits mailing list