[checkmk-commits] Check_MK Git: check_mk: siemens_plc.duration: Producing perfdata even when in critical state

Lars Michelsen lm at mathias-kettner.de
Thu Apr 9 09:35:01 CEST 2015


Module: check_mk
Branch: master
Commit: 45a3271d093c0ce0088a68b37000b78e824c7f32
URL:    http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=45a3271d093c0ce0088a68b37000b78e824c7f32

Author: Lars Michelsen <lm at mathias-kettner.de>
Date:   Thu Apr  9 09:34:57 2015 +0200

siemens_plc.duration: Producing perfdata even when in critical state

---

 checks/siemens_plc |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/checks/siemens_plc b/checks/siemens_plc
index db8dad6..6f59479 100644
--- a/checks/siemens_plc
+++ b/checks/siemens_plc
@@ -144,13 +144,14 @@ def check_siemens_plc_duration(item, params, info):
             else:
                 seconds = int(line[-1])
 
+            perfdata = [(line[1], seconds)]
+
             key = 'siemens_plc.duration.%s' % item
             if key in g_counters and g_counters[key] < seconds:
-                g_counters[key] = seconds
                 return 2, 'Reduced from %s to %s' % (get_age_human_readable(g_counters[key]),
-                                                     get_age_human_readable(seconds))
-            else:
-                g_counters[key] = seconds
+                                                     get_age_human_readable(seconds)), perfdata
+
+            g_counters[key] = seconds
 
             state = 0
             warn, crit = params.get('duration', (None, None))
@@ -159,7 +160,7 @@ def check_siemens_plc_duration(item, params, info):
             elif warn != None and seconds >= warn:
                 state = 1
 
-            return state, get_age_human_readable(seconds), [(line[1], seconds)]
+            return state, get_age_human_readable(seconds), perfdata
 
 
 check_info['siemens_plc.duration'] = {



More information about the checkmk-commits mailing list