[checkmk-commits] [tribe29/checkmk] d82d2e: cached get-check-information

Lars noreply at github.com
Wed Jun 5 09:50:32 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/tribe29/checkmk
  Commit: d82d2e52bdeed67a258e8ad2722a014b1a581667
      https://github.com/tribe29/checkmk/commit/d82d2e52bdeed67a258e8ad2722a014b1a581667
  Author: Andreas Boesl <andreas.boesl at tribe29.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M cmk/gui/plugins/wato/__init__.py
    M cmk/gui/plugins/wato/check_mk_configuration.py
    M cmk/gui/plugins/wato/utils/__init__.py

  Log Message:
  -----------
  cached get-check-information

Change-Id: I12c20b62fba63cf65233be89b34b7af6078dbf33


  Commit: 777d4788cd5351c5ceefd86180b40899cdd6b223
      https://github.com/tribe29/checkmk/commit/777d4788cd5351c5ceefd86180b40899cdd6b223
  Author: Lars Michelsen <lm at mathias-kettner.de>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M bin/check_mk

  Log Message:
  -----------
  Fix "cmk" command exception when invalid sub-options are given

When e.g. a valid mode "--list-hosts" is called with an invalid
sub option, for example "--hex", then an exception like this
could occur:

C+:
OMD[osim]:~$ cmk --debug --list-hosts --hex
Traceback (most recent call last):
  File "/omd/sites/osim/bin/cmk", line 89, in <module>
    exit_status = modes.call(o, a, opts, args)
  File "/omd/sites/osim/lib/python/cmk_base/modes/__init__.py", line 72, in call
    return mode.handler_function(*handler_args)
  File "/omd/sites/osim/lib/python/cmk_base/modes/check_mk.py", line 210, in mode_list_hosts
    hosts = _list_all_hosts(args, options)
  File "/omd/sites/osim/lib/python/cmk_base/modes/check_mk.py", line 227, in _list_all_hosts
    hostnames.update(config_cache.all_active_hosts())
  File "/omd/sites/osim/lib/python/cmk_base/config.py", line 2969, in all_active_hosts
    return self._all_active_hosts
AttributeError: 'CEEConfigCache' object has no attribute '_all_active_hosts'
C-:

This happened because Checkmk did not load the configuration before
executing the mode once an unknown option was in the command line.

Change-Id: I909e59318608589a5a3637f0cbd94e1393b01ce1


Compare: https://github.com/tribe29/checkmk/compare/d20b5a575c11...777d4788cd53


More information about the checkmk-commits mailing list