[omd-devel] omd command is broken

Mathias Kettner mk at mathias-kettner.de
Sun Apr 26 16:21:22 CEST 2015


Hi Sven,

done a few further commits. cp/mv and also the new restore now share the
same code as create for finalizing things.

[...]
ok 153 - exit code: 0 == 0
ok 154 - stdout like /Restarting Apache...\s*OK/
ok 155 - stderr like /^\s*$/
ok 156 - running cmd: /usr/bin/omd rm testsite2
ok 157 - exit code: 0 == 0
ok 158 - stdout like /Restarting Apache...\s*OK/
ok 159 - stderr like /^\s*$/
ok
All tests successful.
Files=1, Tests=159, 51 wallclock secs ( 0.04 usr  0.00 sys +  2.78 cusr 
  6.64 csys =  9.46 CPU)
Result: PASS

Mathias


Am 26.04.2015 um 14:15 schrieb Sven Nierlein:
> Hi Mathias,
>
> the automatic tests revealed 2 issues with the new omd hooks.
> 1. "omd mv/cp" restarts the system apache before running the config_set_all()
>     which starts the system apache with the wrong port number of the site apache.
> 2. On "omd cp", when the apache hook decides to increase the port number, its
>     not beeing saved to ~/etc/omd/site.conf because config_set_all() just runs the
>     hook, but does not care about the return value like config_set_value() would do.
>
> Btw, you can run the automatic tests with
> ./t/test_all.sh ./t/10-omd_testsite.t
> from the source folder as root.
>
> Cheers,
>   Sven
> _______________________________________________
> omd-devel mailing list
> omd-devel at lists.mathias-kettner.de
> http://lists.mathias-kettner.de/mailman/listinfo/omd-devel
>

-- 
We’ll meet in Munich for the 2nd Check_MK Conference!
Book your place now and be part of it.
October 18th-20th, 2015
http://mathias-kettner.de/conference


Wir treffen uns zur 2. Check_MK-Konferenz in München!
Rechtzeitig buchen und dabei sein!
18.-20. Oktober 2015
http://mathias-kettner.de/conference


Mathias Kettner GmbH
Kellerstraße 29, 81667 München, Germany
Registergericht: Amtsgericht München,  HRB 165902
Geschäftsführer: Mathias Kettner
http://mathias-kettner.de
Tel. +49 89 1890 435-0
Fax. +49 89 1890 435-29


More information about the omd-devel mailing list